-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive changes for HttpManager #205
Conversation
Relevant changes: eBay/IOManager#100
seem like you forgot the change on conanfile.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix this
ioenvironment.restart_http_server(); |
This will restart http server and pass empty value for certs. We should only start http server once in SM. This restart should be removed
Sure. |
Yes, changed. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 68.69% 70.13% +1.44%
==========================================
Files 30 30
Lines 1581 1537 -44
Branches 163 160 -3
==========================================
- Hits 1086 1078 -8
+ Misses 408 370 -38
- Partials 87 89 +2 ☔ View full report in Codecov by Sentry. |
Relevant changes: eBay/IOManager#100